This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Merge main into main contract segmentation #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove setup/teardown logic: this was relevant for the block executor (which the validator was copied from) due to concurrency limitations of papyrus. But since we are not using papyrus in PyValidator, these are no longer relevant. In the new flow, multiple `PyValidator` instances can be used concurrently. GlobalCache is currently not threadsafe, so isn't used in PyValidator. To use it, it must be Mutex'ed and updated from Python after each validate call finishes.
…fety native_blockifier: Make PyValidator threadsafe (#1221) Co-Authored-By: Gilad Chase <gilad@starkware.com>
…into-main-v0.13.0 Elin/merge main v0.12.3 into main v0.13.0
Signed-off-by: Dori Medini <dori@starkware.co>
…ro-vm Bump `cairo-vm` to `0.8.3`.
* Update os_resources.json to match the python one * Fix os_resources expected tests * Moar fixes (by dori) Signed-off-by: Dori Medini <dori@starkware.co> * Fix test docstrings Co-Authored-By: Gilad Chase <gilad@starkware.com> Co-Authored-By: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Release 0.4.0
… readability of deploy. (#1258)
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
… parameter into create_test_init_data (#1282)
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
…into-main Elin/merge main v0.13.0 into main
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-contract-segmentation #1291 +/- ##
==============================================================
+ Coverage 70.67% 71.35% +0.67%
==============================================================
Files 57 59 +2
Lines 7209 7299 +90
Branches 7209 7299 +90
==============================================================
+ Hits 5095 5208 +113
+ Misses 1691 1673 -18
+ Partials 423 418 -5 ☔ View full report in Codecov by Sentry. |
elintul
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is