refactor(execution, native_blockifier): remove Py objects from Transa… #1427
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## barak/block_executor/move_pre_process_block #1427 +/- ##
===============================================================================
- Coverage 70.45% 70.38% -0.07%
===============================================================================
Files 60 60
Lines 7774 7773 -1
Branches 7774 7773 -1
===============================================================================
- Hits 5477 5471 -6
- Misses 1866 1871 +5
Partials 431 431 ☔ View full report in Codecov by Sentry. |
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
0c8bc0d
to
c653a44
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/new_without_py_objects
branch
from
f06c933
to
18efcca
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
c653a44
to
586ecbe
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/new_without_py_objects
branch
from
18efcca
to
c10f380
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @barak-b-starkware and @Yoni-Starkware)
a discussion (no related file):
This collides with #1387, consider redefining Yael's util, in order to avoid conflicts.
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware and @Yoni-Starkware)
a discussion (no related file):
Python PR?
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware)
barak-b-starkware
force-pushed
the
barak/block_executor/move_pre_process_block
branch
from
586ecbe
to
d8abfd0
Compare
barak-b-starkware
force-pushed
the
barak/block_executor/new_without_py_objects
branch
2 times, most recently
from
327fab2
to
91d6378
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @barak-b-starkware)
crates/native_blockifier/src/py_block_executor.rs line 335 at r2 (raw file):
} pub fn into_block_context(
Why is this deleted?
Code quote:
into_block_contextcrates/native_blockifier/src/py_state_diff.rs line 167 at r2 (raw file):
block_timestamp: BlockTimestamp(py_block_info.block_timestamp), sequencer_address: ContractAddress::try_from(py_block_info.sequencer_address.0)?, gas_prices: GasPrices {
Any chance to make this shorter?
Consider a for loop and shortening each iteration.
…ute() work w/o Py objects
…lize() work without Py objects
…ctionExecutor::new
barak-b-starkware
force-pushed
the
barak/block_executor/new_without_py_objects
branch
from
91d6378
to
7375293
Compare
barak-b-starkware
changed the base branch from
barak/block_executor/move_pre_process_block
to
barak/block_executor/transaction_executor_finalize
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @barak-b-starkware)
barak-b-starkware
force-pushed
the
barak/block_executor/transaction_executor_finalize
branch
6 times, most recently
from
6bbb895
to
a97ae89
Compare
barak-b-starkware
dismissed
Yoni-Starkware’s stale review
The base branch was changed.
… stderr (starkware-libs#1427) * feat(katana): write katana logs to tempdir and print log file path to stderr * fix: typo and formatting
…ctionExecutor::new
This change is