Elin/merge main v0.13.0 hotfix into main v0.13.1 #1494
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @elintul)
crates/blockifier/src/transaction/transactions_test.rs line 1714 at r3 (raw file):
None; "Positive flow")] #[test_case(
This test should stay for 0.13.1, checking the case that the event exceeds the number of emitted events.
I guess it means that nothing from the 0.13.1-hotfix should be taken.
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @elintul)
crates/blockifier/src/transaction/transactions_test.rs line 1709 at r3 (raw file):
vec![stark_felt!(1_u16); SYSCALL_MAX_EVENT_KEYS], vec![stark_felt!(2_u16); SYSCALL_MAX_EVENT_DATA], 10,
this should be SYSCALL_MAX_N_EMITTED_EVENTS, to test the edge case of sending exactly the max amount of events.
elintul
force-pushed
the
elin/merge-main-v0.13.0-hotfix-into-main-v0.13.1
branch
from
fe3c28e
to
4c55b4a
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)
crates/blockifier/src/transaction/transactions_test.rs line 1709 at r3 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
this should be SYSCALL_MAX_N_EMITTED_EVENTS, to test the edge case of sending exactly the max amount of events.
Done.
crates/blockifier/src/transaction/transactions_test.rs line 1714 at r3 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
This test should stay for 0.13.1, checking the case that the event exceeds the number of emitted events.
I guess it means that nothing from the 0.13.1-hotfix should be taken.
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @elintul)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @elintul)
* fix: borrow? * fix: mut? * feat: use mutex for eventloop and return it * chore: typo & fmt clippy * refactor: return mutexguard * refactor: return arc cloen
This change is