Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Merge main-v0.13.1 into main #1545

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

barak-b-starkware
Copy link
Collaborator

@barak-b-starkware barak-b-starkware commented Feb 18, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f39c098) 69.99% compared to head (576bc35) 69.98%.

Files Patch % Lines
crates/blockifier/src/versioned_constants.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
- Coverage   69.99%   69.98%   -0.01%     
==========================================
  Files          59       59              
  Lines        8221     8220       -1     
  Branches     8221     8220       -1     
==========================================
- Hits         5754     5753       -1     
  Misses       2002     2002              
  Partials      465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @elintul)

@barak-b-starkware barak-b-starkware merged commit e6c69c6 into main Feb 19, 2024
13 of 15 checks passed
@barak-b-starkware barak-b-starkware deleted the barak/merge-main-v0.13.1-into-main branch February 19, 2024 07:04
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
…are-libs#1545)

* Feat: Add total_count on RetrieveEntitiesResponse

* Feat: add count_rows

* fmt

* Fix sql count_query
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants