feat: add the new stack trace to ValidateTransactionError

[zuphitf]

This change is 

[dorimedini-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zuphitf)

a discussion (no related file):
Please add a regression test for this

---

[zuphitf]

Previously, dorimedini-starkware wrote…

Please add a regression test for this

Done.

[dorimedini-starkware]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @zuphitf)

---

crates/blockifier/Cargo.toml line 57 at r3 (raw file):

pretty_assertions.workspace = true
rstest.workspace = true
test-case.workspace = true

only used in tests, right?

Suggestion:

phf.workspace = true
rstest = { workspace = true, optional = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true, features = ["arbitrary_precision"] }
sha3.workspace = true
starknet-crypto.workspace = true
starknet_api = { workspace = true, features = ["testing"] }
strum.workspace = true
strum_macros.workspace = true
thiserror.workspace = true

[dev-dependencies]
assert_matches.workspace = true
pretty_assertions.workspace = true
regex.workspace = true
rstest.workspace = true
test-case.workspace = true

---

crates/blockifier/src/execution/entry_point_test.rs line 1072 at r3 (raw file):

"
        ),
    };

cleaner, no need for regex, checks basically the same thing; or am I missing something?

Suggestion:

    let expected_error_prefix = format!(
        "Transaction validation has failed:
0: Error in the called contract (contract address: {contract_address}, class hash: {class_hash}, \
             selector: {selector}):"
             );
    let expected_error_suffix = match cairo_version {
        CairoVersion::Cairo0 => "An ASSERT_EQ instruction failed: 1 != 0.",
        CairoVersion::Cairo1 => "Execution failed. Failure reason: 0x496e76616c6964207363656e6172696f ('Invalid scenario')."
    };

---

crates/blockifier/src/execution/entry_point_test.rs line 1081 at r3 (raw file):

    let cleaned_actual_error = &re.replace_all(&actual_error_str, "pc=0:*");
    // Compare actual trace to the expected trace (sans pc locations).
    assert_eq!(cleaned_actual_error.to_string(), cleaned_expected_error.to_string());

see above

Suggestion:

    let actual_error = account_tx.execute(state, block_context, true, true).unwrap_err();
    let actual_error_str = actual_error.to_string();
    assert!(actual_error_str.startswith(expected_error_prefix));
    assert!(actual_error_str.endswith(expected_error_suffix));

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zuphitf)

---

crates/blockifier/src/execution/entry_point_test.rs line 1072 at r3 (raw file):

Previously, dorimedini-starkware wrote…

cleaner, no need for regex, checks basically the same thing; or am I missing something?

ah no nevermind... asserting equality is better, you assert the number of frames as well. retracting

---

crates/blockifier/src/execution/entry_point_test.rs line 1081 at r3 (raw file):

Previously, dorimedini-starkware wrote…

see above

ah no nevermind... asserting equality is better, you assert the number of frames as well. retracting

[zuphitf]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/Cargo.toml line 57 at r3 (raw file):

Previously, dorimedini-starkware wrote…

only used in tests, right?

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @zuphitf)