This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
refactor: make validate_rounding_consts public #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriStarkware
force-pushed
the
ori/starknet/versioned_constants/os_constants_class/pr10
branch
from
3505d4a
to
f91d8d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 59 59
Lines 8536 8536
Branches 8536 8536
=======================================
Hits 6357 6357
Misses 1759 1759
Partials 420 420 ☔ View full report in Codecov by Sentry. |
noaov1
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware)
OriStarkware
deleted the
ori/starknet/versioned_constants/os_constants_class/pr10
branch
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
* bump rust to `1.76.0` * wip * clippy * update rust ver in ci * upate dockerfile rust ver * update ci image
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
…-libs#1719) ref starkware-libs#1369 - re-export [reth-metrics-derive](https://github.com/paradigmxyz/reth/tree/v0.2.0-beta.4/crates/metrics/metrics-derive) crate from dojo-metrics - rename metrics -> dojo-metrics crate - re-export core metrics stuff from dojo-metrics --- this PR relies on starkware-libs#1720 bcs reth's MSRV is 1.76.0, otherwise can't build reth-metrics-derive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is