fix(concurrency): stop the transaction committer when the scheduler is done

[avi-starkware]

This change is 

[Yoni-Starkware]

Cool, how did you find this?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @noaov1)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (d924c79) to head (a1b8d05).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files          62       62           
  Lines        8895     8895           
  Branches     8895     8895           
=======================================
  Hits         6993     6993           
  Misses       1455     1455           
  Partials      447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[avi-starkware]

@barak-b-starkware said his flow test got stuck in an infinite loop, so I tried to think of places where the scheduler might get stuck.
This is probably not the bug from Barak's flow test because his flow test does not use the method halt_scheduler, but it is still a bug.

[Yoni-Starkware]

Then @OriStarkware must see this bug in his env. Please make sure

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware, @meship-starkware, @noaov1, and @OriStarkware)

[barak-b-starkware]

crates/blockifier/src/concurrency/scheduler.rs line 31 at r1 (raw file):

            *self.commit_index_guard < self.scheduler.chunk_size,
            "The commit index must be less than the chunk size, since the scheduler is not done."
        );

Why do we need this assertion? It feels trivial/redundant. What do I miss here?

Code quote:

        assert!(
            *self.commit_index_guard < self.scheduler.chunk_size,
            "The commit index must be less than the chunk size, since the scheduler is not done."
        );