This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
chore: make FeatureContract::cairo_version public #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for tests with parameterized version. Also moved private functions to appear after public ones, *no logic changes there*.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-mempool #2002 +/- ##
=============================================
Coverage 83.46% 83.46%
=============================================
Files 45 45
Lines 7270 7270
Branches 7270 7270
=============================================
Hits 6068 6068
Misses 828 828
Partials 374 374 ☔ View full report in Codecov by Sentry. |
MohammadNassar1
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for tests with parameterized version.
Also moved private functions to appear after public ones, no logic changes there.
This change is