fix(transaction): change deploy_account default version to be V3

[meship-starkware]

This change is 

[meship-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 234 at r1 (raw file):

    let constructor_calldata = calldata![ctor_grind_arg, ctor_storage_arg];
    let deploy_tx_args = deploy_account_tx_args! {
        class_hash,

it only worked here without the resource bounds

---

crates/blockifier/src/transaction/transactions_test.rs line 1399 at r1 (raw file):

    let mut nonce_manager = NonceManager::default();
    let undeclared_hash = class_hash!("0xdeadbeef");
    let deploy_account = deploy_account_tx(

It only worked here without the resource bounds.

[noaov1]

Please rebase over maon-v0.13.2

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @meship-starkware)

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 226 at r2 (raw file):

            version: TransactionVersion::ONE,
        },
        &mut NonceManager::default(),

Suggestion:

    let deploy_account_tx_1 = deploy_account_tx(
        deploy_account_tx_args! {
            class_hash: account_without_validation.get_class_hash(),
            resource_bounds: l1_resource_bounds(u64::from(!zero_bounds), DEFAULT_STRK_L1_GAS_PRICE),
        },
        &mut NonceManager::default(),

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 246 at r2 (raw file):

    let deployed_account_balance_key = get_fee_token_var_address(account_address);
    let fee_token_address = chain_info.fee_token_address(&FeeType::Strk);

Can you please extract it from account_tx_2?

Code quote:

   let fee_token_address = chain_info.fee_token_address(&FeeType::Strk);

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 261 at r2 (raw file):

        s.spawn(move || {
            let result = account_tx_2.execute(&mut state_2, &block_context_2, true, true);
            result.unwrap();

Why?

Code quote:

            let result = account_tx_2.execute(&mut state_2, &block_context_2, true, true);
            result.unwrap();

[meship-starkware]

Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @noaov1)

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 261 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why?

for Debug will revert

[meship-starkware]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)

---

crates/blockifier/src/concurrency/versioned_state_test.rs line 226 at r2 (raw file):

            version: TransactionVersion::ONE,
        },
        &mut NonceManager::default(),

Done.

[noaov1]

Reviewed 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)