Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

fix: contract class version mismatch format #2082

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jul 14, 2024

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier/src/test_utils.rs line 50 at r1 (raw file):

                                       erc20_contract_without_some_syscalls_compiled.json";

// TODO: Aviv(14/7/2024):Move from test utils module, and use it in ContractClassVersionMismatch

Suggestion:

// TODO(Aviv, 14/7/2024): Move

Copy link
Collaborator Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/blockifier/src/test_utils.rs line 50 at r1 (raw file):

                                       erc20_contract_without_some_syscalls_compiled.json";

// TODO: Aviv(14/7/2024):Move from test utils module, and use it in ContractClassVersionMismatch

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit 8f09ea1 into main-v0.13.2 Jul 14, 2024
28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants