Use BlockNumber in GetBlockHashRequest.

[ArniStarkware]

This change is 

[ArniStarkware]

crates/blockifier/src/execution/syscalls/mod.rs line 304 at r2 (raw file):

        let block_number_as_felt = stark_felt_from_ptr(vm, ptr)?;
        let block_number =
            BlockNumber(u64::try_from(usize::try_from(block_number_as_felt)?).map_err(|_| {

There is a correctness issue here.
Can be solved if the following PR is merged into starknet-api: https://reviewable.io/reviews/starkware-libs/starknet-api/87

Code quote:

u64::try_from(usize::try_from(block_number_as_felt)?

[dafnamatsry]

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[dafnamatsry]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[ArniStarkware]

crates/blockifier/src/execution/syscalls/mod.rs line 304 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

There is a correctness issue here.
Can be solved if the following PR is merged into starknet-api: https://reviewable.io/reviews/starkware-libs/starknet-api/87

Talked with @Yoni-Starkware . Let us merge this PR for now.
The only harm that this correctness issue would do is:

1. Some valid requests will not be processed.
2. The requests that will not be processed are for block_number >= 2^32. This will not be an issue in the following week.

[noaov1]

Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

---

crates/blockifier/src/execution/syscalls/mod.rs line 306 at r3 (raw file):

                    string: block_number_as_felt.to_string(),
                })
            })?);

WDYT?

Suggestion:

    let block_number = vm.get_integer(*ptr)?;
    let block_number = felt.to_u64().ok_or_else(|| {
        SyscallExecutionError::StarknetApiError(StarknetApiError::OutOfRange {
            string: felt.to_string(),
        })
    })?;

[ArniStarkware]

crates/blockifier/src/execution/syscalls/mod.rs line 306 at r3 (raw file):

Previously, noaov1 (Noa Oved) wrote…

WDYT?

Looks great!
See the solution in the following PR:

[noaov1]

Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

crates/blockifier/src/execution/syscalls/mod.rs line 306 at r3 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Looks great!
See the solution in the following PR:

See #668.