This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Prevent version 0 attack on argent accounts. #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoni-Starkware
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase and @noaov1)
dorimedini-starkware
added a commit
that referenced
this pull request
Jun 21, 2023
* Limit recursion depth for entrypoint calls (#612) Currently too many recursions hit stack-overflow panic, we don't want that. Increasing the stack size to 72MB is required in order to have the same recursion depth as in CPython, 3000. This is X36 times the 2MB default, is there a better way? * Prevent version 0 attack on argent accounts. (#627) * Fix segment_arena resource counting. (#613) * Add NonceManager (#628) Signed-off-by: Dori Medini <dori@starkware.co> * Transaction execution failures log-level warn->debug (#626) * Fix recursion depth count. (#631) * Update contract syntax. (#623) * Implement create_test_state (#629) Signed-off-by: Dori Medini <dori@starkware.co> * Expose chain names to python (#633) Signed-off-by: Dori Medini <dori@starkware.co> * Add PRIVATE_SN_POTC_MOCK_GOERLI chain name. (#634) * Don't close executor inside finalize (#630) Move responsibility to caller. Rationale: finalize isn't guaranteed to be run, which might leave dangling read transactions. * Add comment in `Cargo.toml`. (#624) * Don't check chain ID validity (#637) Signed-off-by: Dori Medini <dori@starkware.co> * Dori/limit run with resources (#635) * Limit run with RunResources Signed-off-by: Dori Medini <dori@starkware.co> * Add test Signed-off-by: Dori Medini <dori@starkware.co> * Convert hints to string using ` serde_json::to_string ` (as opposed to ` to_string() `). (#642) * Insert send message to L1 command to both validate and execute. For PR #601 debug. (#606) * Merge remote-tracking branch 'origin/main-v0.12.0' into 'origin/main' * Resolve conflicts Signed-off-by: Dori Medini <dori@starkware.co> Co-Authored-By: giladchase <gilad@starkware.co> Co-Authored-By: Alon Haramati <91828241+alonh5@users.noreply.github.com> Co-Authored-By: Noa Oved <104720318+noaov1@users.noreply.github.com> Co-Authored-By: Yoni <78365039+Yoni-Starkware@users.noreply.github.com> Co-Authored-By: ilyalesokhin-starkware <ilya@starkware.co> Co-Authored-By: amosStarkware <88497213+amosStarkware@users.noreply.github.com> Co-Authored-By: Elin <elin@starkware.co> Co-Authored-By: mohammad-starkware <130282237+MohammadNassar1@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is