Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Use error handling for relocatable addition. #658

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

alonh5
Copy link
Collaborator

@alonh5 alonh5 commented Jun 25, 2023

This change is Reviewable

Copy link
Collaborator Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From cairo-rs:

/// Warning: may panic if self.offset + rhs exceeds usize::MAX
impl AddAssign<usize> for Relocatable {
    fn add_assign(&mut self, rhs: usize) {
        self.offset += rhs
    }
}

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @elintul and @spapinistarkware)

@alonh5 alonh5 force-pushed the alonh/handle_relocatable_overflow branch from 25f5a2a to 70ed361 Compare June 25, 2023 13:33
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks!

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@alonh5 alonh5 merged commit 6a7c8a3 into main-v0.12.0 Jun 25, 2023
3 checks passed
@alonh5 alonh5 deleted the alonh/handle_relocatable_overflow branch June 25, 2023 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants