Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Change initial_gas to be of type u64 . #675

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

noaov1
Copy link
Collaborator

@noaov1 noaov1 commented Jun 28, 2023

This change is Reviewable

@noaov1 noaov1 force-pushed the noa/convert_initial_gas_to_u64 branch from 079653a to 15348f6 Compare June 28, 2023 06:24
elintul
elintul previously approved these changes Jun 28, 2023
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @giladchase and @noaov1)


crates/blockifier/src/execution/entry_point.rs line 57 at r1 (raw file):

    pub caller_address: ContractAddress,
    pub call_type: CallType,
    pub initial_gas: u64,

Consider adding a short comment about the fact the it should suffice.

Code quote:

pub initial_gas: u64,

crates/blockifier/src/execution/deprecated_syscalls/mod.rs line 293 at r1 (raw file):

    )?;

    let initial_gas = constants::INITIAL_GAS_COST;

I think we can lose this variable now, throughout the code.

Code quote:

let initial_gas = constants::INITIAL_GAS_COST;

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@noaov1 noaov1 merged commit 4c8ccdb into main-v0.12.0 Jun 28, 2023
3 checks passed
@noaov1 noaov1 deleted the noa/convert_initial_gas_to_u64 branch June 28, 2023 12:36
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
* Migrate to Cairo 2.1.0

* fix katana breaking changes

* Update set inline macro

* InlineMacro test setup

* Implement get macro

* Remove deps logic

* merge main

* Format

* Dont index entity components by default

* Implement new component keys pattern

* Typed keys trait

* Update get macro

* Remove query

* Fix tests

* Update erc20 implementation

* Fix ci issues

* Fix examples

* Format

* Fix component value serialization

* Update gen

* Additional cleanup

* Avoid rebuild if artifacts already exist

* CI fixes (starkware-libs#708)

* Inlinemacros (starkware-libs#709)

* Return when the target path already exists

* Add packages to compile

* Component class hash updated

For starkware-libs#675
Makes sense for class hash to be changed coz compiled code is now different.

* compute contract address for receipt

* Remove partitions

* Format

---------

Co-authored-by: Kariy <ammr.arf@gmail.com>
Co-authored-by: Shramee Srivastav <shramee.srivastav@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants