Add secp256k1_new request and response.

[ilyalesokhin-starkware]

This change is 

[ilyalesokhin-starkware]

crates/blockifier/src/execution/syscalls/mod.rs line 491 at r1 (raw file):

    // The id of the ec point.
    pub ec_point: usize,

do you want me to put
pub ec_point: Option

here and move the comment to the impl?

Code quote:

    // The syscall returns `Option<Secp256k1Point>` which is represented as two felts in Cairo0.

    // 1 if the point is not on the curve, 0 otherwise.
    pub not_on_curve: bool,

    // The id of the ec point.
    pub ec_point: usize,

[elintul]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware and @noaov1)

---

crates/blockifier/src/execution/execution_utils.rs line 109 at r1 (raw file):

) -> Result<BigUint, VirtualMachineError> {
    let low = vm.get_integer(*ptr)?;
    *ptr += 1;

x2

Suggestion:

*ptr = (*ptr + 1)?;

---

crates/blockifier/src/execution/syscalls/mod.rs line 22 at r1 (raw file):

    SyscallHintProcessor,
};
use super::execution_utils::u256_from_ptr;

Suggestion:

crate::execution

---

crates/blockifier/src/execution/syscalls/mod.rs line 484 at r1 (raw file):

#[derive(Debug, Eq, PartialEq)]

pub struct Secp256k1NewResponse {

Remove blank line above.

Code quote:

pub struct Secp256k1NewResponse {

[elintul]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @noaov1)

---

crates/blockifier/src/execution/syscalls/secp.rs line 28 at r2 (raw file):

#[derive(Debug, Eq, PartialEq)]

pub struct Secp256k1NewResponse {

Remove blank line above.

Code quote:

pub struct Secp256k1NewResponse {

[ilyalesokhin-starkware]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @elintul and @noaov1)

---

crates/blockifier/src/execution/syscalls/secp.rs line 28 at r2 (raw file):

Previously, elintul (Elin) wrote…

Remove blank line above.

done.

[elintul]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)