Made unreachable code diagnostics from errors into warnings.

commit-id:59b91bc5
starkware-libs · Aug 22, 2024 · 5384a8c · 5384a8c
1 parent ce2718e
commit 5384a8c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/crates/cairo-lang-lowering/src/diagnostic.rs b/crates/cairo-lang-lowering/src/diagnostic.rs
@@ -1,6 +1,7 @@
 use cairo_lang_defs::diagnostic_utils::StableLocation;
 use cairo_lang_diagnostics::{
     DiagnosticAdded, DiagnosticEntry, DiagnosticLocation, DiagnosticNote, DiagnosticsBuilder,
+    Severity,
 };
 use cairo_lang_semantic as semantic;
 use cairo_lang_semantic::corelib::LiteralError;
@@ -84,6 +85,13 @@ impl DiagnosticEntry for LoweringDiagnostic {
         }
     }
 
+    fn severity(&self) -> Severity {
+        match self.kind {
+            LoweringDiagnosticKind::Unreachable { .. } => Severity::Warning,
+            _ => Severity::Error,
+        }
+    }
+
     fn notes(&self, _db: &Self::DbType) -> &[DiagnosticNote] {
         &self.location.notes
     }

diff --git a/crates/cairo-lang-lowering/src/test_data/tests b/crates/cairo-lang-lowering/src/test_data/tests
@@ -45,7 +45,7 @@ foo
 //! > semantic_diagnostics
 
 //! > lowering_diagnostics
-error: Unreachable code
+warning: Unreachable code
  --> lib.cairo:3:5
     5;
     ^^