Added destructors in cycle detectors.

[orizi]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/borrow_check/mod.rs line 33 at r1 (raw file):

    success: Maybe<()>,
    block_extra_calls: OrderedHashMap<BlockId, Vec<FunctionId>>,
    destruct_fn: TraitFunctionId,

Suggestion:

destruct_trait

[ilyalesokhin-starkware]

Reviewed 2 of 8 files at r1, all commit messages.
Reviewable status: 2 of 8 files reviewed, 1 unresolved discussion (waiting on @orizi)

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/borrow_check/mod.rs line 158 at r1 (raw file):

                            &[
                                (panic_demand, Some(DropPosition::Panic(stmt.location))),
                                (info.clone(), Some(DropPosition::Panic(stmt.location))),

what happend to this?

Code quote:

info.clone(), Some(DropPosition::Panic(stmt.location)

[orizi]

Reviewable status: 2 of 8 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/borrow_check/mod.rs line 33 at r1 (raw file):

    success: Maybe<()>,
    block_extra_calls: OrderedHashMap<BlockId, Vec<FunctionId>>,
    destruct_fn: TraitFunctionId,

it is the fn id - not the trait.

---

crates/cairo-lang-lowering/src/borrow_check/mod.rs line 158 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

what happend to this?

the location became larger - so i extract it to a variable.

[ilyalesokhin-starkware]

Reviewed 1 of 8 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)