-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added conversion from span to fixed sized array. #5582
Conversation
7c83f01
to
ec5d295
Compare
ec5d295
to
7814bab
Compare
7814bab
to
1f25cd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
This is not really a tuple; it is a structure where all the members are of the same type, there is no user type check, right? Code quote: Validates that the given type is a tuple with all members of the same type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-sierra/src/extensions/modules/array.rs
line 131 at r1 (raw file):
ty: ConcreteTypeId, ) -> Result<LibfuncSignature, SpecializationError> { let member_type = validate_tuple_and_fetch_ty(context, &ty)?;
This libfunc can be used to create any user type, right?
Code quote:
let member_type = validate_tuple_and_fetch_ty(context, &ty)?;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-sierra/src/extensions/modules/array.rs
line 131 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
This libfunc can be used to create any user type, right?
any user type with all members of the same type, and sized.
crates/cairo-lang-sierra/src/extensions/modules/array.rs
line 156 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
This is not really a tuple; it is a structure where all the members are of the same type, there is no user type check, right?
it is checked to be tuple like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-sierra/src/extensions/modules/array.rs
line 156 at r1 (raw file):
Previously, orizi wrote…
it is checked to be tuple like.
document that any user type is considered a tuple.
commit-id:78f53cb7
1f25cd7
to
cb14a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @TomerStarkware)
crates/cairo-lang-sierra/src/extensions/modules/array.rs
line 156 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
document that any user type is considered a tuple.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
Stack:
This change is