Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conversion from span to fixed sized array. #5582

Merged
merged 1 commit into from
May 21, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 19, 2024

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra/src/extensions/modules/array.rs line 156 at r1 (raw file):

}

/// Validates that the given type is a tuple with all members of the same type, and returns the type

This is not really a tuple; it is a structure where all the members are of the same type, there is no user type check, right?

Code quote:

Validates that the given type is a tuple with all members of the same type

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)


crates/cairo-lang-sierra/src/extensions/modules/array.rs line 131 at r1 (raw file):

        ty: ConcreteTypeId,
    ) -> Result<LibfuncSignature, SpecializationError> {
        let member_type = validate_tuple_and_fetch_ty(context, &ty)?;

This libfunc can be used to create any user type, right?

Code quote:

 let member_type = validate_tuple_and_fetch_ty(context, &ty)?;

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra/src/extensions/modules/array.rs line 131 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

This libfunc can be used to create any user type, right?

any user type with all members of the same type, and sized.


crates/cairo-lang-sierra/src/extensions/modules/array.rs line 156 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

This is not really a tuple; it is a structure where all the members are of the same type, there is no user type check, right?

it is checked to be tuple like.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-sierra/src/extensions/modules/array.rs line 156 at r1 (raw file):

Previously, orizi wrote…

it is checked to be tuple like.

document that any user type is considered a tuple.

@orizi orizi force-pushed the pr/orizi/multi-pop/78f53cb7 branch from 1f25cd7 to cb14a09 Compare May 20, 2024 09:10
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @TomerStarkware)


crates/cairo-lang-sierra/src/extensions/modules/array.rs line 156 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

document that any user type is considered a tuple.

Done.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 07f1c0d May 21, 2024
85 checks passed
@orizi orizi deleted the pr/orizi/multi-pop/78f53cb7 branch June 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants