Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option tests. #5919

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Added option tests. #5919

merged 1 commit into from
Jun 30, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jun 30, 2024 •
edited by liorgold2
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

@orizi orizi requested a review from gilbens-starkware June 30, 2024 09:20
@orizi orizi enabled auto-merge June 30, 2024 09:20
@orizi
Added option tests.
cb117f9 
commit-id:33d8470f
@orizi orizi force-pushed the pr/orizi/option/33d8470f branch from 216dd11 to cb117f9 Compare June 30, 2024 09:23
@orizi orizi mentioned this pull request Jun 30, 2024
Merged
@orizi orizi requested a review from TomerStarkware June 30, 2024 09:23
TomerStarkware
TomerStarkware approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jun 30, 2024
Merged via the queue into main with commit 0f16b2c Jun 30, 2024
44 checks passed
@orizi orizi deleted the pr/orizi/option/33d8470f branch July 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerStarkware TomerStarkware TomerStarkware approved these changes

@gilbens-starkware gilbens-starkware Awaiting requested review from gilbens-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orizi @TomerStarkware