Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more proper code mappings in starknet plugins. #6227

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 18, 2024

Refactored a bit on the way.


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi force-pushed the pr/orizi/updates/e1b0c9fb branch from 51d56e4 to 834791b Compare August 19, 2024 14:55
@orizi orizi force-pushed the pr/orizi/updates/1102d2a4 branch from 2c814f8 to 3d60a56 Compare August 19, 2024 14:55
@orizi orizi changed the base branch from pr/orizi/updates/e1b0c9fb to main August 20, 2024 03:43
@orizi orizi force-pushed the pr/orizi/updates/1102d2a4 branch from 3d60a56 to 8080ed0 Compare August 20, 2024 03:43
@orizi orizi changed the base branch from main to pr/orizi/updates/9e8383ea August 20, 2024 03:43
@orizi orizi force-pushed the pr/orizi/updates/9e8383ea branch from cb2a0ff to f334f07 Compare August 20, 2024 05:42
@orizi orizi force-pushed the pr/orizi/updates/1102d2a4 branch from 8080ed0 to 6b70617 Compare August 20, 2024 05:42
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, @gilbens-starkware, and @piotmag769)

Refactored a bit on the way.

commit-id:1102d2a4
@orizi orizi force-pushed the pr/orizi/updates/1102d2a4 branch from 6b70617 to 3bfb75e Compare August 20, 2024 10:42
@orizi orizi changed the base branch from pr/orizi/updates/9e8383ea to main August 20, 2024 10:42
@orizi orizi enabled auto-merge August 20, 2024 10:42
@orizi orizi added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 855271a Aug 20, 2024
44 checks passed
@piotmag769 piotmag769 removed their request for review August 20, 2024 12:47
@orizi orizi deleted the pr/orizi/updates/1102d2a4 branch August 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants