Made non-copy variable not be forwarded in const folding.

[orizi]

Fixes #6321.

---

Stack:

• Made non-copy variable not be forwarded in const folding. #6324 ⬅
• Made derive have code mapping for the arg causing the derive. #6314
• Made mapped_text based on Into<String>. #6313

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/test_data/const_folding line 3019 at r1 (raw file):

  (v3: (core::felt252, core::dict::Felt252Dict::<core::felt252>), v4: @(core::felt252, core::dict::Felt252Dict::<core::felt252>)) <- snapshot(v2)
  (v5: core::felt252, v6: core::dict::Felt252Dict::<core::felt252>) <- struct_destructure(v3)
  (v7: core::dict::SquashedFelt252Dict::<core::felt252>) <- core::dict::Felt252DictImpl::<core::felt252, core::Felt252Felt252DictValue>::squash(v6)

before the fix.

Suggestion:

  (v7: core::dict::SquashedFelt252Dict::<core::felt252>) <- core::dict::Felt252DictImpl::<core::felt252, core::Felt252Felt252DictValue>::squash(v1)

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 29 at r2 (raw file):

/// Keeps track of equivalent values that a variables might be replaced with.
/// Note: We don't keep track of types as we assume the usage is always correct.

is this comment still relevent?

Code quote:

/// Note: We don't keep track of types as we assume the usage is always correct.

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r2 (raw file):

    /// The variable is a struct of other variables.
    Struct(Vec<VarInfo>),
    /// A placeholder for building constructing a struct containing a const, for the unknown parts.

?

Code quote:

building constructing

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 41 at r2 (raw file):

    Struct(Vec<VarInfo>),
    /// A placeholder for building constructing a struct containing a const, for the unknown parts.
    Placeholder,

Maybe None or undefined?

Code quote:

Placeholder

[orizi]

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 29 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

is this comment still relevent?

it didn't use to be - but it is now (since we added the snapshots)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

?

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 41 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

Maybe None or undefined?

Done.

[ilyalesokhin-starkware]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r2 (raw file):

Previously, orizi wrote…

Done.

fix comment as well.

[orizi]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

fix comment as well.

Done.

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 39 at r4 (raw file):

    Snapshot(Box<VarInfo>),
    /// The variable is a struct of other variables.
    Struct(Vec<VarInfo>),

consider using option instead of untracked.

Suggestion:

 Struct(Vec<Option<VarInfo>>),

[ilyalesokhin-starkware]

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r4 (raw file):

    /// The variable is a struct of other variables.
    Struct(Vec<VarInfo>),
    /// A marker for inner `VarInfo`s to be untracked - enables building recursive `VarInfo`s

Suggestion:

Enables building VarInfo::Structs where some of the members are untracked.

[orizi]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 39 at r4 (raw file):

Previously, ilyalesokhin-starkware wrote…

consider using option instead of untracked.

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 40 at r4 (raw file):

    /// The variable is a struct of other variables.
    Struct(Vec<VarInfo>),
    /// A marker for inner `VarInfo`s to be untracked - enables building recursive `VarInfo`s

No longer relevant.

[ilyalesokhin-starkware]

Reviewed 1 of 1 files at r5.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion