Remove unneeded allows - or make them expect instead.
#6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
orizi
force-pushed
the
spr/main/2a6ce1b3
branch
from
007e330 to
e09cc4d
Compare
orizi
force-pushed
the
spr/main/3f0039b9
branch
from
4b58060 to
2db4e6e
Compare
This was referenced Oct 7, 2024
Merged
ilyalesokhin-starkware
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
orizi
force-pushed
the
spr/main/3f0039b9
branch
from
2db4e6e to
db58380
Compare
ilyalesokhin-starkware
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
orizi
force-pushed
the
spr/main/2a6ce1b3
branch
from
c73b6bc to
63c8f9e
Compare
orizi
force-pushed
the
spr/main/3f0039b9
branch
from
db58380 to
e797004
Compare
commit-id:3f0039b9
orizi
force-pushed
the
spr/main/3f0039b9
branch
from
e797004 to
47efcf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
allows - or make themexpectinstead. #6461 ⬅This change is