Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving current inference state prior to finding index traits. #6587

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 5, 2024

Finxing issue #6580

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/solve-pre-index branch from cd7d07e to cf1e22d Compare November 5, 2024 08:53
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 3 of 5 files at r2.
Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @TomerStarkware)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@orizi orizi added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit c60f2a3 Nov 5, 2024
47 checks passed
@orizi orizi deleted the orizi/solve-pre-index branch November 7, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: array of nested arrays indexing throws a compiler error unless into() is invoked on 1st index
3 participants