Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forwarding of attributes in generated structs and enums. #6739

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 26, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi linked an issue Nov 26, 2024 that may be closed by this pull request
@orizi orizi force-pushed the spr/main/756fd75b branch from e905e40 to 5b38aec Compare November 26, 2024 11:33
@orizi orizi force-pushed the spr/main/eff05d51 branch from d8afef4 to 7e4a655 Compare November 26, 2024 11:33
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 40 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, @integraledelebesgue, @mkaput, and @orizi)


crates/cairo-lang-language-server/src/config.rs line 45 at r2 (raw file):

    /// The property is set by the user under the `cairo1.enableProcMacros` key in client
    /// configuration.
    pub enable_proc_macros: bool,

Rebase pls

@orizi orizi changed the base branch from spr/main/756fd75b to main November 26, 2024 15:38
@orizi orizi enabled auto-merge November 26, 2024 15:38
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 24 files at r3.
Reviewable status: 24 of 40 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @gilbens-starkware, @integraledelebesgue, and @mkaput)

Copy link
Collaborator

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 24 of 40 files reviewed, all discussions resolved (waiting on @Draggu, @gilbens-starkware, @integraledelebesgue, and @mkaput)

@orizi orizi added this pull request to the merge queue Nov 26, 2024
@orizi orizi removed this pull request from the merge queue due to a manual request Nov 26, 2024
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, 24 of 24 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 1df6a1d Nov 27, 2024
49 checks passed
@orizi orizi deleted the spr/main/eff05d51 branch November 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: LegacyMap
5 participants