Added option for renaming a storage varialble path. #6758
Merged
+237
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This change is |
orizi
force-pushed
the
spr/main/10bc0eb2
branch
from
1c4290f to
ff6815c
Compare
gilbens-starkware
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/cairo_level_tests/renamed_storage_test.cairo line 38 at r1 (raw file):
fn rename_test() { let mut state = contract::contract_state_for_testing(); //let state = @contract::contract_state_for_testing();
commit-id:10bc0eb2
orizi
commented
Nov 28, 2024
There was a problem hiding this comment.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/cairo_level_tests/renamed_storage_test.cairo line 38 at r1 (raw file):
fn rename_test() { let mut state = contract::contract_state_for_testing(); //let state = @contract::contract_state_for_testing();
Done.
orizi
force-pushed
the
spr/main/10bc0eb2
branch
from
ff6815c to
c2ff0e2
Compare
gilbens-starkware
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.