add v3 transactions and missing fields to receipts & block header #131

ArielElp · 2023-09-02T04:37:58Z

This change is

DelevoXDG · 2023-09-02T15:25:25Z

api/starknet_api_openrpc.json

+                                "description": "Version of the transaction scheme",
+                                "type": "string",
+                                "enum": [
+                                    "0x2"


Shouldn't it be 0x3? 👀

DelevoXDG · 2023-09-02T15:28:28Z

api/starknet_api_openrpc.json

-                    "execution_status": {
-                        "title": "Execution status",
-                        "$ref": "#/components/schemas/TXN_EXECUTION_STATUS"
+                    "execution_reources": {


Typo, I think it should be "execution_resources"

EvyatarO

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 21 unresolved discussions (waiting on @ArielElp and @DelevoXDG)

api/starknet_api_openrpc.json line 1370 at r1 (raw file):

                    },
                    "l1_gas_price": {
                        "title": "L1 gas price",

You need to have to gas price fields (eth and strk)

api/starknet_api_openrpc.json line 1799 at r1 (raw file):

            },
            "DECLARE_TXN_V3": {
                "title": "Declare Transaction V2",

V3?

api/starknet_api_openrpc.json line 1800 at r1 (raw file):

            "DECLARE_TXN_V3": {
                "title": "Declare Transaction V2",
                "description": "Declare Contract Transaction V2",

V3?

api/starknet_api_openrpc.json line 1814 at r1 (raw file):

                            },
                            "sender_address": {
                                "title": "Sender address",

Don't you want to use the common fields in one place?

api/starknet_api_openrpc.json line 1823 at r1 (raw file):

                                "$ref": "#/components/schemas/FELT"
                            },
                            "max_fee": {

no max_fee

api/starknet_api_openrpc.json line 1833 at r1 (raw file):

                                "type": "string",
                                "enum": [
                                    "0x2"

0x3

api/starknet_api_openrpc.json line 1854 at r1 (raw file):

                                "$ref": "#/components/schemas/RESOURCE_LIMITS"
                            },
                            "l2_gas": {

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
Same for tip, da_mode and init_data

api/starknet_api_openrpc.json line 1880 at r1 (raw file):

                            }
                        },
                        "required": [

There is no max_fee
l2_gas, tip, paymaster_address,nonce and fee data_availability mode are not requires ATM

api/starknet_api_openrpc.json line 1920 at r1 (raw file):

                    },
                    {
                        "title": "Broadcasted invoke transaction V2",

Why v2?

api/starknet_api_openrpc.json line 2058 at r1 (raw file):

                    {
                        "type": "object",
                        "title": "Declare txn v2",

V3?

api/starknet_api_openrpc.json line 2078 at r1 (raw file):

                            },
                            "max_fee": {
                                "title": "Max fee",

Not exist in v3

api/starknet_api_openrpc.json line 2106 at r1 (raw file):

                            },
                            "l2_gas": {
                                "title": "L2 Gas",

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

api/starknet_api_openrpc.json line 2131 at r1 (raw file):

                            }
                        },
                        "required": [

See comment in invoke

api/starknet_api_openrpc.json line 2235 at r1 (raw file):

                    },
                    "max_fee": {
                        "title": "Max fee",

Doesn't exist in v3

api/starknet_api_openrpc.json line 2276 at r1 (raw file):

                    },
                    "l2_gas": {
                        "title": "L2 Gas",

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

api/starknet_api_openrpc.json line 2301 at r1 (raw file):

                    }
                },
                "required": [

See comment above

api/starknet_api_openrpc.json line 2493 at r1 (raw file):

                                ]
                            },
                            "sender_address": {

Don't you want to create an object for common fields?

api/starknet_api_openrpc.json line 2523 at r1 (raw file):

                                "$ref": "#/components/schemas/RESOURCE_LIMITS"
                            },
                            "l2_gas": {

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

api/starknet_api_openrpc.json line 3579 at r1 (raw file):

                "properties": {
                    "max_amount": {
                        "title": "max amount",

max_amount_per_unit?

tomek0123456789 · 2023-09-08T10:46:25Z

Just reminding that starknet_traceBlockTransactions should accept BLOCK_ID instead of BLOCK_HASH

ArielElp

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 21 unresolved discussions (waiting on @DelevoXDG and @EvyatarO)

api/starknet_api_openrpc.json line 1370 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

You need to have to gas price fields (eth and strk)

Added (still need to add the exact unit in the description; are we going with 10^-18?)

api/starknet_api_openrpc.json line 1799 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

V3?

Done.

api/starknet_api_openrpc.json line 1800 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

V3?

Done.

api/starknet_api_openrpc.json line 1823 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

no max_fee

Done.

api/starknet_api_openrpc.json line 1833 at r1 (raw file):

Previously, DelevoXDG (Maksim Zdobnikau) wrote…

Shouldn't it be 0x3? 👀

Done.

api/starknet_api_openrpc.json line 1833 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

0x3

Done.

api/starknet_api_openrpc.json line 1854 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
Same for tip, da_mode and init_data

Removed all. We should add them as required in the corresponding version.

api/starknet_api_openrpc.json line 1880 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

There is no max_fee
l2_gas, tip, paymaster_address,nonce and fee data_availability mode are not requires ATM

Done.

api/starknet_api_openrpc.json line 1920 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

Why v2?

Done.

api/starknet_api_openrpc.json line 2058 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

V3?

Done.

api/starknet_api_openrpc.json line 2078 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

Not exist in v3

Done.

api/starknet_api_openrpc.json line 2106 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

Deleted until it's actually relevant

api/starknet_api_openrpc.json line 2131 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

See comment in invoke

Done.

api/starknet_api_openrpc.json line 2235 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

Doesn't exist in v3

Done.

api/starknet_api_openrpc.json line 2276 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

Done.

api/starknet_api_openrpc.json line 2301 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

See comment above

Done.

api/starknet_api_openrpc.json line 2523 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

it's part of v3 but you shouldn't send it on v0.13.0, should we keep it here in the meantime?
(Same for tip, volition fields, init code)

Done.

api/starknet_api_openrpc.json line 3579 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

max_amount_per_unit?

What's max_amount_per_unit? ATM there's max_amount and max_price_per_unit

EvyatarO

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @ArielElp and @DelevoXDG)

api/starknet_api_openrpc.json line 1370 at r1 (raw file):

Previously, ArielElp wrote…

Added (still need to add the exact unit in the description; are we going with 10^-18?)

We are going w/ 10^-18, still no name yet.

api/starknet_api_openrpc.json line 3579 at r1 (raw file):

Previously, ArielElp wrote…

What's max_amount_per_unit? ATM there's max_amount and max_price_per_unit

You are correct.

ArielElp

Dismissed @EvyatarO from 4 discussions.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @DelevoXDG and @EvyatarO)

api/starknet_api_openrpc.json line 1814 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

Don't you want to use the common fields in one place?

These objects used to be less readable when non-flat, I rather keep it flat for now until we can completely remove old transaction types.

api/starknet_api_openrpc.json line 2493 at r1 (raw file):

Previously, EvyatarO (Evyatar) wrote…

Don't you want to create an object for common fields?

These objects used to be less readable when non-flat, I rather keep it flat for now until we can completely remove old transaction types.

api/starknet_api_openrpc.json line 3043 at r1 (raw file):

Previously, DelevoXDG (Maksim Zdobnikau) wrote…

👀

?

ArielElp

Reviewed 2 of 3 files at r3, 1 of 1 files at r4.
Dismissed @DelevoXDG from a discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ArielElp)

api/starknet_api_openrpc.json line 3043 at r1 (raw file):

Previously, DelevoXDG (Maksim Zdobnikau) wrote…

Typo, I think it should be "execution_resources"

Ah true, thanks!

ArielElp

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

introduce v3 transaction and add missing fields

0ad1d8e

ArielElp requested a review from EvyatarO September 2, 2023 04:37

add type to traces

db46881

DelevoXDG reviewed Sep 2, 2023

View reviewed changes

EvyatarO requested changes Sep 4, 2023

View reviewed changes

rianhughes mentioned this pull request Sep 6, 2023

RPCv0.5 Implementation NethermindEth/starknet.go#306

Closed

16 tasks

DelevoXDG mentioned this pull request Sep 7, 2023

Trace API software-mansion/starknet.py#1175

Merged

1 task

remove future resources, add gas price units to block

5d266c1

ArielElp commented Sep 10, 2023

View reviewed changes

EvyatarO requested changes Sep 10, 2023

View reviewed changes

add specVersion endpoint and re-allow v0 invoke txs

83f925d

ArielElp commented Sep 10, 2023

View reviewed changes

remove v3 from broadcasted_txn until the relevant Starknet upgrade

2bbe96f

joshklop mentioned this pull request Sep 11, 2023

Supporting starknet_protocolVersion #132

Open

ArielElp added 2 commits September 13, 2023 19:46

add ordering to trace events and messages

8f93316

fix typo

df8e2d5

ArielElp commented Sep 13, 2023

View reviewed changes

ArielElp merged commit cddef47 into master Sep 13, 2023
1 check passed

ArielElp deleted the v0.5.0 branch September 13, 2023 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add v3 transactions and missing fields to receipts & block header #131

add v3 transactions and missing fields to receipts & block header #131

ArielElp commented Sep 2, 2023 •

edited by EvyatarO

Loading

DelevoXDG Sep 2, 2023

DelevoXDG Sep 2, 2023

DelevoXDG Sep 10, 2023

EvyatarO left a comment

tomek0123456789 commented Sep 8, 2023

ArielElp left a comment

EvyatarO left a comment

ArielElp left a comment

ArielElp left a comment

ArielElp left a comment

add v3 transactions and missing fields to receipts & block header #131

add v3 transactions and missing fields to receipts & block header #131

Conversation

ArielElp commented Sep 2, 2023 • edited by EvyatarO Loading

DelevoXDG Sep 2, 2023

Choose a reason for hiding this comment

DelevoXDG Sep 2, 2023

Choose a reason for hiding this comment

DelevoXDG Sep 10, 2023

Choose a reason for hiding this comment

EvyatarO left a comment

Choose a reason for hiding this comment

tomek0123456789 commented Sep 8, 2023

ArielElp left a comment

Choose a reason for hiding this comment

EvyatarO left a comment

Choose a reason for hiding this comment

ArielElp left a comment

Choose a reason for hiding this comment

ArielElp left a comment

Choose a reason for hiding this comment

ArielElp left a comment

Choose a reason for hiding this comment

ArielElp commented Sep 2, 2023 •

edited by EvyatarO

Loading