fix(plugins/plugin-client-common): in browser mode, tab offline may r…

…esult in react loading error part of kubernetes-sigs#7967
starpit · Sep 13, 2021 · cb9462f · cb9462f
1 parent dec65a0
commit cb9462f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/plugins/plugin-client-common/src/components/spi/Alert/impl/PatternFly.tsx b/plugins/plugin-client-common/src/components/spi/Alert/impl/PatternFly.tsx
@@ -15,7 +15,12 @@
  */
 
 import React from 'react'
-import { Alert, AlertActionCloseButton } from '@patternfly/react-core'
+
+// ugh, avoid backdrop.css parse errors in plugin prescan
+const Alert = React.lazy(() => import('@patternfly/react-core').then(_ => ({ default: _.Alert })))
+const AlertActionCloseButton = React.lazy(() =>
+  import('@patternfly/react-core').then(_ => ({ default: _.AlertActionCloseButton }))
+)
 
 import { Props } from '..'
 import '../../../../../web/scss/components/Alert/PatternFly.scss'

diff --git a/plugins/plugin-client-common/src/components/spi/Alert/index.tsx b/plugins/plugin-client-common/src/components/spi/Alert/index.tsx
@@ -17,10 +17,14 @@
 import React from 'react'
 import Props from './model'
 
-const PatternFly = React.lazy(() => import('./impl/PatternFly'))
+import PatternFly from './impl/PatternFly'
 
 export { Props }
 
 export default function AlertSpi(props: Props): React.ReactElement {
-  return <PatternFly {...props} />
+  return (
+    <React.Suspense fallback={<div />}>
+      <PatternFly {...props} />
+    </React.Suspense>
+  )
 }