Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (ci): Do not terminate prematurely without showing GAME_IMAGE_VERSION_LINES when verifying image fails #166

Conversation

leojonathanoh
Copy link
Member

@leojonathanoh leojonathanoh commented Nov 16, 2023

No description provided.

@leojonathanoh leojonathanoh self-assigned this Nov 16, 2023
@leojonathanoh leojonathanoh added this to the v1.26.1 milestone Nov 16, 2023
Copy link
Member

@joeltimothyoh joeltimothyoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joeltimothyoh joeltimothyoh force-pushed the fix/ci-do-not-terminate-prematurely-without-showing-game-image-version-lines-when-verifying-image-fails branch from ac489e0 to 0b6e6f5 Compare November 17, 2023 05:19
@joeltimothyoh joeltimothyoh merged commit 9ba010e into startersclan:master Nov 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants