Skip to content

Commit

Permalink
Add testing-library/jest-dom types for pnpm
Browse files Browse the repository at this point in the history
pnpm installs these types to node_modules/.pnpm by default, so we need
to explicitly add this dependency.

See testing-library/jest-dom#123 (comment)
  • Loading branch information
venables committed Mar 24, 2023
1 parent e1e9ba6 commit 9d77998
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 15 deletions.
30 changes: 15 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,29 @@

1. Clone this repo to your desired path:

```sh
git clone git@github.com:startkit-dev/startkit-next.git my-new-project
```
```sh
git clone git@github.com:startkit-dev/startkit-next.git my-new-project
```

2. Rename the project:

```sh
./bin/rename
```
```sh
./bin/rename
```

3. Update your git remote to point to StartKit as `upstream`

```sh
git remote rename origin upstream
```
```sh
git remote rename origin upstream
```

In the future, you'll be able to pull in the latest StartKit changes without
missing a beat by running:
In the future, you'll be able to pull in the latest StartKit changes without
missing a beat by running:
```sh
git fetch upstream
git pull upstream/main
```
```sh
git fetch upstream
git pull upstream/main
```
## Getting Started
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@types/node": "^18.11.19",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.11",
"@types/testing-library__jest-dom": "^5.14.5",
"@typescript-eslint/eslint-plugin": "^5.48.0",
"autoprefixer": "^10.4.13",
"eslint": "^8.33.0",
Expand Down
2 changes: 2 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 9d77998

@vercel
Copy link

@vercel vercel bot commented on 9d77998 Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.