Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markerTagToScene] reduce logging #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

p0rnb0x
Copy link
Contributor

@p0rnb0x p0rnb0x commented Nov 5, 2024

This plugins logs lot of JSON and other info. I disable JSON log and convert other one from Info to Debug.

@DogmaDragon
Copy link
Contributor

I don't think having less complete log by default is preferred. If you feel like it's excessive you can modify your plugin locally.

And the change from Info to Debug doesn't make sense in that content. It's just reporting the mode used. Unless I misunderstand something?

@p0rnb0x
Copy link
Contributor Author

p0rnb0x commented Dec 2, 2024

I don't think having less complete log by default is preferred.

neither is dumping everything at Info level.

If you feel like it's excessive you can modify your plugin locally.

already have; feel free to close this PR if you consider the current log statements appropriate at Info level.

It's just reporting the mode used.

correct; which obviously is for Debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants