Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action $confirm = false doesn't disable confirm #1497

Closed
riasvdv opened this issue Mar 12, 2020 · 1 comment
Closed

Action $confirm = false doesn't disable confirm #1497

riasvdv opened this issue Mar 12, 2020 · 1 comment

Comments

@riasvdv
Copy link
Contributor

riasvdv commented Mar 12, 2020

If I set

protected $confirm = false;

On my own Action, it still requires confirmation
@jasonvarga
Copy link
Member

Nice find.

@jasonvarga jasonvarga added the bug label Mar 12, 2020
jesseleite added a commit that referenced this issue Sep 17, 2020
@jesseleite
Merge pull request #2446 from edalzell/no-confirmation-actions
e6694d7 
if action doesn’t need to be confirmed, run it (Closes #1497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonvarga @riasvdv