Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revealer fieldtype shows label redundantly. #2468

Closed
theblacksheepltd opened this issue Sep 18, 2020 · 5 comments
Closed

Revealer fieldtype shows label redundantly. #2468

theblacksheepltd opened this issue Sep 18, 2020 · 5 comments

Comments

@theblacksheepltd
Copy link

Bug Description

In revealer fieldtype documentation, sample shows as a button with the display property used as the label. In CP, both the button and a standard field label are displayed. It seems that for its intended purpose, the label should not display.

How to Reproduce

Add revealer field to blueprint or fieldset and set display property.

Extra Detail

Environment

Statamic version: 3.0.*

PHP version: 7.3

Install method (choose one):

  • Fresh install from statamic/statamic
@duncanmcclean
Copy link
Member

I'm unable to reproduce this issue.

I've copied the field configuration from the Statamic documentation:

  -
    handle: revealed
    field:
      type: text
      display: 'I am revealed!'
      if:
        behold: 'equals true'
  -
    handle: behold
    field:
      type: revealer
      display: 'Behold!'

With that configuration, I can't see the field label of the revealer field, see this screencast.

I'm going to close this issue and presume it's been fixed. If you encounter this issue again, reply on this issue with a short screencast and I can have another look.

@theblacksheepltd
Copy link
Author

theblacksheepltd commented Sep 20, 2020 via email

@duncanmcclean
Copy link
Member

Thanks for providing more information. I’ll re-open this issue.

@robdekort
Copy link
Contributor

Possibly linked to #2289

@jackmcdade
Copy link
Member

jackmcdade commented Sep 22, 2020

Fixed in 255ac14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants