Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG tag outputs aria attributes without a value #2605

Closed
robdekort opened this issue Oct 7, 2020 · 3 comments
Closed

SVG tag outputs aria attributes without a value #2605

robdekort opened this issue Oct 7, 2020 · 3 comments
Labels
accessibility tags

Comments

@robdekort
Copy link
Contributor

robdekort commented Oct 7, 2020 •
edited
Loading

Bug Description

The SVG tag outputs aria attributes like aria-hidden="true" as aria-hidden. This is invalid according to lighthouse and this article.

How to Reproduce

Add an SVG tag
Give it an attribute like aria-hidden=true
Run lighthouse

Extra Detail

This:
Screenshot 2020-10-07 at 11 23 00

Outputs this:
Screenshot 2020-10-07 at 11 23 12

Environment

Statamic 3.0.16 Pro
Laravel 7.28.4
PHP 7.4.10
@duncanmcclean
Copy link
Member

duncanmcclean commented Oct 7, 2020 •
edited
Loading

This seems to happen to any attributes added to the {{ svg }} tag, where the value is true.

@duncanmcclean duncanmcclean mentioned this issue Oct 7, 2020
Closed
@duncanmcclean
Copy link
Member

I've created a pull request to fix this bug.. #2613.

@robdekort
Copy link
Contributor Author

You sir are a champ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with using boolean attributes on SVG tag
2 participants
@duncanmcclean @robdekort