Fix issues with using boolean attributes on SVG tag #2613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like somebody didn't check the tests when they made the change 👀 🙈 I'll fix that later. |
|
Noticed we needed some changes around this stuff anyway. Figured it'd be quicker to just do it than explain it. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you add an attribute, like
aria-hidden="true"to an SVG tag, the value won't be returned. As pointed out by Lighthouse in the related issue, this is considered to be invalid. (it would be returned simply asaria-hidden)However, with this pull request, the value of true will now be output like it should be:
aria-hidden="true".This PR fixes #2605.