[5.x] Adjust sorting and comparison implementations #9692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adjustments to the sorting and comparison implementation. For the multisort implementation itself, it prepares the sort column and direction outside of the
uasort
callback to reduce the number ofexplode
calls. Additionally, it resolves theCompare
instance once from the service container and reuses it.For the Comparator, it moves the
class_exists(Collator::class)
call out of thestrings
method. TheStr::lower
calls were also refactored to justmb_strtolower
.These combined changes reduced control panel load times by ~ 1.5-2 seconds for 20K+ entries.