-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Consolidated WIP Items #9588
Closed
JohnathonKoster
wants to merge
147
commits into
statamic:master
from
JohnathonKoster:consolidated-items-wip
Closed
[5.x] Consolidated WIP Items #9588
JohnathonKoster
wants to merge
147
commits into
statamic:master
from
JohnathonKoster:consolidated-items-wip
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consolidated-items-wip
Positive improvements across a variety of different situations, particularly the `group_by` modifier
This reverts commit d5ced64.
Closing now that there's just the one PR left: #9636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate branch to make it easier to test the following, which all interact together. Descriptions provided for convenience; they may not match current PR titles.
💾 Stache Related
🌍🌎🌏 Globals
🌳 Structure/Tree Related
referenceExists
inside the structureTreeBuilder
#9676 Reuse results ofreferenceExists
when building structure treespluck
when validating CollectionStructure trees #9687 Usepluck
to get entry IDs when validating trees🟦🖨️Augmentation Related
nav
tag to prefer bulk augmentation, reworks{{ dump }}
and its friends to materialize delayed values for debugging🏎️ Instance Caching
AugmentedPage
getComputedCallbacks
for a given scope #9640 - Cache results ofgetComputedCallbacks
->routes()
getComputedCallbacks
on Entry instances #9642 - Reduce complexity ofcollection()
method and cachegetComputedCallbacks
on Entry instancessite
method on entry #9650 - Cachesite
method results on Entryentry
method on Page instances #9659 - Cache results ofentry
method on Page instances🍦 General Cleanup/Reduce Extra Work
FluentGetterSetter
fieldsCache
is reset #9585 - Reduce the number of times a blueprint's field cache is clearedStr
call forwarding for 🌶️ methods #9637 - RemoveStr
call forwarding for methods used in hot code pathsisApiRoute
results for the request #9638 - CacheStatamic::isApiRoute()
for the requestorigin
andhasOrigin
FieldtypeRepository::find()
calls to a property #9643 - Caches results ofField::fieldtype()
to reduce calls to underlying FieldtypeRepositoryisExternal
to reduce the amount of work done 🧯🔥dated()
method #9649 - Remove getter/setter from Collectiondated()
method to reduce overall amount of work done 🧯🔥collection()
methodmultisort
, reduce number of timesclass_exists
is called withinComparator
🛠️⚙️ General Utilities