Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Cache a collection tree's structure on the instance #9644

Merged
merged 3 commits into from
Mar 12, 2024
Merged

[5.x] Cache a collection tree's structure on the instance #9644

merged 3 commits into from
Mar 12, 2024

Conversation

JohnathonKoster
Copy link
Contributor

This PR adds an instance cache to the CollectionTree class to reduce the number of times Blink is called for structure()

@JohnathonKoster JohnathonKoster mentioned this pull request Mar 3, 2024
Closed
37 tasks
jasonvarga
jasonvarga previously requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target master and adjust the PR title to show [5.x].

@JohnathonKoster JohnathonKoster changed the base branch from 4.x to master March 8, 2024 01:05
@JohnathonKoster JohnathonKoster changed the title [4.x] Cache a collection tree's structure on the instance [5.x] Cache a collection tree's structure on the instance Mar 8, 2024
@jasonvarga jasonvarga dismissed their stale review March 11, 2024 16:57

Requested changes were made.

@jasonvarga jasonvarga merged commit 8d6bec3 into statamic:master Mar 12, 2024
16 checks passed
@jasonvarga jasonvarga deleted the collection-tree-cache-structure branch March 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnathonKoster @jasonvarga