[5.x] Simplify collection and cache getComputedCallbacks on Entry instances
#9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the Blink call for collection is unfortunate, its still an improvement over the repeated getter/setter calls in this method due to how many times it is called. Cache invalidation complexity here is not worth it at this time
37 tasks
JohnathonKoster
changed the title
getComputedCallbacks on Entry instancesgetComputedCallbacks on Entry instances
|
On a page with a 5-item nav and 3 entries being listed, this results in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the getter/setter logic for
collectioninto the Entry class itself instead of using getter/setter. Additionally, it caches the results ofgetComputedCallbackson the instance itself. These two methods are called very frequently, and removing the extra closures/new object instances helps over many thousands of entries.Note for local testing: if you pull this in, you will likely need a
php please stache:clear