-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Allows for entries to receive index items during hydration #9587
Closed
JohnathonKoster
wants to merge
15
commits into
statamic:master
from
JohnathonKoster:allow-hydration-from-stache-indexes
Closed
[5.x] Allows for entries to receive index items during hydration #9587
JohnathonKoster
wants to merge
15
commits into
statamic:master
from
JohnathonKoster:allow-hydration-from-stache-indexes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
jasonvarga
reviewed
Apr 2, 2024
The NodeTypeAnalyzer needs to know about tag names ahead of time when parsing content. Augmentation can cause environment details to be reloaded. When uris are not *always* augmented, this behavior does not always happen. This commit makes this behavior explicit to account for any dynamic processes, test cases, etc.
Merged
Thank you for this! Closing in favor of #9844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows entries to receive items from the Stache indexes during the hydration process. Currently it is only being used to restore the
uri
property on entries from the Stache to avoid invoking the UrlBuilder if we already have it.