[5.x] Fix is_external_url
modifier with Link fields
#10027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
is_external_url
modifier where it'd error out when passed a Link field.The error is actually coming from inside the
URL::isExternal
method, with the caching changes introduced in #9646. The method is expecting a string be passed to it instead of anArrayableLink
object like is the case w/ Link fields.This worked fine in v4 because
ArrayableLink
casts to a string but with the recent caching changes, it's trying to get items in an array usingArrayableLink
as a key which doesn't work. I though converting the value to a string before it ends up inisExternal
might be the best way to fix it.Fixes #10026.