Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Dark Mode for the Control Panel #10073

Closed
wants to merge 1 commit into from
Closed

Conversation

peimn
Copy link
Contributor

@peimn peimn commented May 14, 2024

Carefully curated hues designed to ease eye strain during nighttime work sessions, which often dominate our schedules. 🌚🌃

Replaces #9929.

@duncanmcclean duncanmcclean changed the title [5.x] Apply dark mode [5.x] Dark Mode for the Control Panel May 14, 2024
@jackmcdade
Copy link
Member

This is looking really good, thank you for all your hard work! I need to do a super thorough review of course, and I think we might need one more dark shade of grey to get some of the contrasts right, but i'd say it's probably 90% of the way there. <3 <3

@peimn
Copy link
Contributor Author

peimn commented May 17, 2024

Of course, I understand that it's not perfect, and some colors might need adjustment. The icons could use better coloring, and the grids need some consideration. The dark mode toggle itself could simply be represented by an icon.

@jackmcdade
Copy link
Member

Closing in favor of #10117 (couldn't push to this PR). Huge thank you @peimn – i fiddled with it a ton but you have my deepest thanks and all the credit ❤️

@jackmcdade jackmcdade closed this May 20, 2024
@peimn peimn deleted the 5-dark-mode branch May 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants