Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Restore nav/structure select behavior #10240

Closed
wants to merge 2 commits into from
Closed

[5.x] Restore nav/structure select behavior #10240

wants to merge 2 commits into from

Conversation

JohnathonKoster
Copy link
Contributor

This PR restores the functionality of the nav tag's select parameter. The BulkAugmentor did not know how to resolve those; this PR adds the ability to specify a custom callback that will be used to retrieve augmentation keys. When present, the bulk augmentor will utilize this. If the callback returns null, it will default to its original behavior.

The nav tag uses its getQuerySelectKeys method as its callback to avoid copying that logic into the BulkAugmentor

@jasonvarga
Copy link
Member

What's the difference to my implementation here? #10226

@JohnathonKoster JohnathonKoster closed this by deleting the head repository Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants