[5.x] Prevent additional augmented search result data from being lost #10301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10251 by only running the bulk augmentation process in Antlers when a collection contains
BulkAugmentableinstances. Additionally, theResultclass'stoDeferredAugmentedArraywill now return the results oftoAugmentedCollectionto ensure the extra search data is added.Notes for review: I had originally looked into simply adjusting the what the
Resultaugments to, but decided against that since it could be quite the unexpected change for anyone doing stuff the results ofnewAugmentedInstanceonResultobjects. If curious, that was implemented here: 5.x...JohnathonKoster:cms:search-result-augmentation and makes it Just Work ™️ with the bulk augmentation stuff. However, with this PR, I think having it check forinstanceof BulkAugmentableis a good idea for anything else that may have been missed.