Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix blueprint override logic #10661

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[5.x] Fix blueprint override logic #10661

merged 1 commit into from
Aug 19, 2024

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Aug 19, 2024

While reviewing #9327 I noticed that there's some behavioral issues with how blueprint overrides work.

  • When you have a custom namespace, and the vendor override directory exists (e.g. blueprints/vendor/custom), if the directory is empty, you see no blueprints at all. Not even ones that haven't been overridden.
  • If there are any overrides in that directory, only they are shown. Non-overridden ones do not get displayed.
  • If you have a yaml file in the override directory that doesn't exist in the regular directory, it gets shown. It shouldn't. You shouldn't be able to override a blueprint that doesn't exist. You're overriding, not adding. (Up for debate I guess, but it was ambiguous so I went with this.) Reverted in [5.x] Fix blueprint override logic, pt 2 #10668

@jasonvarga jasonvarga marked this pull request as ready for review August 19, 2024 18:47
@jasonvarga jasonvarga merged commit a0c51aa into 5.x Aug 19, 2024
19 checks passed
@jasonvarga jasonvarga deleted the blueprint-overrides branch August 19, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant