[5.x] Fix blueprint override logic #10661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #9327 I noticed that there's some behavioral issues with how blueprint overrides work.
vendor
override directory exists (e.g.blueprints/vendor/custom
), if the directory is empty, you see no blueprints at all. Not even ones that haven't been overridden.If you have a yaml file in the override directory that doesn't exist in the regular directory, it gets shown. It shouldn't. You shouldn't be able to override a blueprint that doesn't exist. You're overriding, not adding. (Up for debate I guess, but it was ambiguous so I went with this.)Reverted in [5.x] Fix blueprint override logic, pt 2 #10668