[5.x] Fix asset browser history navigation #10948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This couldn't possibly have been broken since 2017 when the browser navigation was built. 🤔 |
|
@jasonvarga Can't say, I frankly only noticed because a customer kept asking about it 🙃 |
|
Maybe it was? Seems broken all the way back to 3.2. I can't easily test any earlier than that without changing my dev setup. Funny! Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History navigation currently doesn't work inside the asset browser. Going back and forth updates the url and shows a loading indicator, but it doesn't update the current folder or its contents. This PR re-enables it by watching the selected path prop and updating the current path from the watcher whenever the passed-in path changes.
Closes #10920