Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Avoid showing asset upload fixes when inappropriate #10986

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Oct 21, 2024

Fixes #10980

I went with a 409 Conflict status as it seems the most appropriate:

The request could not be completed due to a conflict with the current state of the target resource. This code is used in situations where the user might be able to resolve the conflict and resubmit the request.

Now you will only get the option to "fix" the upload when its due to being a duplicate. Regular validation errors and file size limit issues will not.

CleanShot 2024-10-21 at 11 48 36

@jasonvarga jasonvarga merged commit 2bb4ae1 into 5.x Oct 21, 2024
17 checks passed
@jasonvarga jasonvarga deleted the dupe-validation branch October 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate asset handling interface shows when uploading unknown filetype
1 participant