[5.x] Support glide urls with URL params #11003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't tested this, but... Since the "path" is now the url without the query string, wouldn't this break if you had a URL structure where multiple images used the same url? Like |
|
Yep thats fair, it wouldn't have worked. I've pushed this which should solve that case. |
jasonvarga
previously requested changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Glide to handle external urls with query params... eg: an instagram url like
https://instagram.fbhd1-1.fna.fbcdn.net/v/t39.30808-6/459037616_18451217146036976_8749080258714687081_n.jpg?stp=dst-jpg_e35_s640x640_sh0.08&_nc_ht=instagram.fbhd1-1.fna.fbcdn.net&_nc_cat=108&_nc_ohc=4NMeg8elDJwQ7kNvgE1xSf8&_nc_gid=bb5d8bab5b84475797c0c5171eed8c1c&edm=APU89FAAAAAA&ccb=7-5&oh=00_AYCPWoEYVRiQPq2YmVzVEiYCmxC7rGDoJbR-r2o7DYePNg&oe=671F02D7&_nc_sid=bc0c2cCloses: #7172