Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefixed locale on multi sites from glide url #1842

Closed
wants to merge 1 commit into from
Closed

Remove prefixed locale on multi sites from glide url #1842

wants to merge 1 commit into from

Commits on May 16, 2020

  1. Remove prefixed locale on multi sites from glide url 

    When using a multisite, glide will prefix the current locale. As a result, the images can't be found anymore. 

A workaround has been, to create symlinks or mess with the Nginx config. 

Can't we solve this problem via PHP? Are there cases, where it does make sense to have the locale prefixed to the images?
It would be easy to a config setting inside the assets config file to disable this behavior if someone wants this behavior.

This change would instantly make glide images available on all multisites, without messing with symlinks or config files. 

Obviously this code does need a refactor. Before doing that, I wanted to discuss this and ask if such kind of behavior would be merged at all?
    Jonas Siewertsen authored May 16, 2020
    Configuration menu
    Copy the full SHA
    b3b8a19 View commit details
    Browse the repository at this point in the history