Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix searchable item checking #2643

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Fix searchable item checking #2643

merged 6 commits into from
Oct 12, 2020

Commits on Oct 12, 2020

  1. add tests

    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    ec89ab7 View commit details
    Browse the repository at this point in the history

  2. The property is already the handle

    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    17723f8 View commit details
    Browse the repository at this point in the history

  3. Improve tests and add "contains" assertions

    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    aff72b8 View commit details
    Browse the repository at this point in the history

  4. Optimize checking if an item belongs to the searchables ... 

    Rather than getting all the items again (which would have a ton of overhead in the case of lots of assets, for example) just check against the configured rules.
    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    6852e65 View commit details
    Browse the repository at this point in the history

  5. one line

    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    de7bc38 View commit details
    Browse the repository at this point in the history

  6. Prevent random classes being indexed

    @jasonvarga
    jasonvarga committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    4442a85 View commit details
    Browse the repository at this point in the history