Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary orWheres #6460

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Remove unnecessary orWheres #6460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Stache/Query/EntryQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'
return parent::where($column, $operator, $value, $boolean);
}

public function orWhere($column, $operator = null, $value = null)
{
return $this->where($column, $operator, $value, 'or');
}

public function whereIn($column, $values, $boolean = 'and')
{
if (in_array($column, ['collection', 'collections'])) {
Expand All @@ -39,11 +34,6 @@ public function whereIn($column, $values, $boolean = 'and')
return parent::whereIn($column, $values, $boolean);
}

public function orWhereIn($column, $values)
{
return $this->whereIn($column, $values, 'or');
}

protected function collect($items = [])
{
return EntryCollection::make($items);
Expand Down
10 changes: 0 additions & 10 deletions src/Stache/Query/TermQueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'
return parent::where($column, $operator, $value, $boolean);
}

public function orWhere($column, $operator = null, $value = null)
{
return $this->where($column, $operator, $value, 'or');
}

public function whereIn($column, $values, $boolean = 'and')
{
if (in_array($column, ['taxonomy', 'taxonomies'])) {
Expand All @@ -50,11 +45,6 @@ public function whereIn($column, $values, $boolean = 'and')
return parent::whereIn($column, $values, $boolean);
}

public function orWhereIn($column, $values)
{
return $this->whereIn($column, $values, 'or');
}

protected function collect($items = [])
{
return TermCollection::make($items);
Expand Down